moveit / moveit_resources

URDFs, meshes, and config packages for MoveIt testing
65 stars 118 forks source link

[ROS2]: Add a new parameter to panda's xacro to select ros2_control hardware interface type #158

Closed JafarAbdi closed 1 year ago

JafarAbdi commented 1 year ago

This depends on https://github.com/ros-planning/moveit2/pull/1805.

This's needed for a tutorial I'm writing on how to use moveit with isaac through https://github.com/PickNikRobotics/isaac_ros2_control/

I bet we could add gazebo and ignition without any problem, but I didn't test it!

<xacro:if value="${ros2_control_hardware_type == 'gazebo'}">
  <plugin>gazebo_ros2_control/GazeboSystem</plugin>
</xacro:if>
<xacro:if value="${ros2_control_hardware_type  == 'ignition'}">
  <plugin>ign_ros2_control/IgnitionSystem</plugin>
</xacro:if>
JafarAbdi commented 1 year ago

Why do you remove the clang-format check??? If this is really intended, this should become part of another PR. Better fix clang-format (also in a separate PR!), which is broken here because of GHA's switch from Ubuntu 20.04 to 22.04 (in the latter clang-format-10 is not available anymore. So, either stick to ubuntu-20.04 or update to a newer version of clang-format, which comes with new options and new formatting though. An upgrade should be discussed, e.g. in the next maintainer meeting.

We don't have any cpp code here (we don't have .clang-format file either), that's why I removed it! I'll revert the last commit and open a separate PR

tylerjw commented 1 year ago

I pushed a rebase on the ros2 branch to re-trigger format CI job.