moveit / moveit_resources

URDFs, meshes, and config packages for MoveIt testing
65 stars 118 forks source link

Add pre-release test to CI [master] #70

Closed tylerjw closed 3 years ago

tylerjw commented 3 years ago

This one adds the pre-release test and sets it to run when there is a push to the master branch or when there is a workflow-dispatch. Because it runs on a bush to the master branch it won't block any PRs but it will let us know at any time if the pre-release test is failing on the master branch.

This also cleans up a few other CI things:

tylerjw commented 3 years ago

I pushed a change to both this and the melodic-devel version that adds moveit as a downshtream dependency in the pre-release test.

tylerjw commented 3 years ago

Testing here: https://github.com/tylerjw/moveit_resources/runs/2477268464

tylerjw commented 3 years ago

Reading the industrial_ci code for pre-release it seems it does support ccache. I added that back in to speed up the pre-release builds.

That reporting the test results action only really works when you are making pull requests (becasue what it does is provide summaries of the test results in a comment in the pull request). There are two reasons that's not useful here, we are not running pre-release tests on PRs and that sort of reporting only works when the pull request comes from the repo itself instead of from a fork. There is a workaround in the readme for that second issue but it looks to be fairly nasty.

tylerjw commented 3 years ago

@rhaschke I think ccache might work in pre-release, or it might be possible to make it work. See: https://github.com/ros-industrial/industrial_ci/issues/667

tylerjw commented 3 years ago

Testing here: https://github.com/tylerjw/moveit_resources/runs/2487302852

rhaschke commented 3 years ago

I think, this PR might be pending for a while, until ccache issues and test results reporting is fully resolved. Independent of this, I triggered a release: https://github.com/ros/rosdistro/pull/29384

tylerjw commented 3 years ago

I will remove the ccache from these PRs so we can merge them. I did push tags but didn't bloom because I was unable to get pre-release tests to pass for either noetic or melodic if you include the release branch of moveit in the test.

tylerjw commented 3 years ago

For some reason, planning_scene_monitor.cpp is built twice: once in section "build in isolation" and once in section "run_tests". Why the latter and why it cannot find the header anymore?

I don't know... I should have looked more closely at the output. I have no idea why this would happen.

vatanaksoytezer commented 3 years ago

Closing since this is merged with #81