[joy.py] Installed python file might not be executable.

moveit / moveit_ros

THIS REPO HAS MOVED TO https://github.com/ros-planning/moveit

70 stars 118 forks source link

[joy.py] Installed python file might not be executable. #691

Closed 130s closed 8 years ago

130s commented 8 years ago

$ ll /opt/ros/indigo/lib/python2.7/dist-packages/moveit_ros_visualization/moveit_joy.py
-rw-r--r-- 1 root root 23K Apr 12 12:01 /opt/ros/indigo/lib/python2.7/dist-packages/moveit_ros_visualization/moveit_joy.py
$ dpkg -p ros-indigo-moveit-ros-visualization | grep Ver
Version: 0.7.1-0trusty-20160618-030142-0700

130s commented 8 years ago

Initially I pulled too many wrong commits by mistake, which is fixed now.

v4hn commented 8 years ago

Hey Isaac,

I think this should actually be install(PROGRAMS instead of FILES. CMake takes care of the rest then.

130s commented 8 years ago

How cool is that! Updated.

130s commented 8 years ago

@v4hn looks like you cherry-picked this into indigo-devel. Thanks for doing that! It'd be even nicer if you mentioned having done so. Thanks!

v4hn commented 8 years ago

On Mon, Jun 20, 2016 at 01:59:06PM -0700, Isaac I.Y. Saito wrote:

@v4hn looks like you cherry-picked this into indigo-devel. Thanks for doing that! It'd be even nicer if you mentioned having done so. Thanks!

Ah, yes. Sorry, I forgot to add a notice. -.-" Shouldn't happen of course.

davetcoleman commented 8 years ago

If you are backporting a change I think it should be through the PR mechanism so that someone else can double check it

130s commented 8 years ago

Back to original issue, which is how moveit_ros.py gets installed, I remember I asked a question (and am still waiting for answers). I guess we need to use "catkin-way" for installing python.