Closed toliver closed 8 years ago
Heya,
Actually I was thinking of adding this request myself after I found out Shadow has their own patchset which they provide for their users. So a big +1 to have this request here.
However, the branch, as it is, is quite a mess...
(1) Could you please use git rebase
to get rid of
all the merge commits? This is pretty straight forward
and I already did this once locally last month...
(2) Could you please squash the fixup commits together with the commits introducing the code? At least 0f1a9f7 , 5f9bbac and c4a1f51 should definitely be only one commit.
The same goes for 056bf8b and 997d8ba .
sorry, I mixed up commit ids, just updated the ids in the previous comment.
Hi @v4hn. Yes, sorry for the mess. I wasn't sure if this PR would be of interest. I'm glad it is. I will tidy up the commits.
Closing. Rebased version in #694