search

moveit / moveit_ros

THIS REPO HAS MOVED TO https://github.com/ros-planning/moveit
69 stars 118 forks source link

Add methods to retrieve named states via the move_group #694

Closed toliver closed 8 years ago

toliver commented 8 years ago

Rebased version of #693

toliver commented 8 years ago

I have just realized that there were new comments on the previous PR. Let's see if we can address them soon.

dg-shadow commented 8 years ago

Thanks for comments @v4hn and @davetcoleman. They're now hopefully addressed. Let me know if there are any further issues / questions.

davetcoleman commented 8 years ago

+1, but can you squash the commits into 1? Thanks!

dg-shadow commented 8 years ago

Ah, ok, misunderstood. Compressed to one per patch but happy to put them all together instead. On 27 Jun 2016 6:41 p.m., "Dave Coleman" notifications@github.com wrote:

+1, but can you squash the commits into 1? Thanks!

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/ros-planning/moveit_ros/pull/694#issuecomment-228818747, or mute the thread https://github.com/notifications/unsubscribe/ADLS1QaD6zzrQmS-Sm7zIzHYglf-ziwvks5qQAsvgaJpZM4I9Ifl .

Shadow Robot Company Ltd. 251 Liverpool Road, N1 1LX, UK

Registered Number 3308007 (England & Wales)

v4hn commented 8 years ago

+1. I'd merge directly.. This is three entirely different things, so why would you merge them dave?

davetcoleman commented 8 years ago

Ah I didn't look carefully, I assumed they were just addendums to the original PR. Nice work @dg-shadow

dg-shadow commented 8 years ago

Thanks guys :)

On 27 June 2016 at 19:16, Dave Coleman notifications@github.com wrote:

Merged #694 https://github.com/ros-planning/moveit_ros/pull/694.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ros-planning/moveit_ros/pull/694#event-705323151, or mute the thread https://github.com/notifications/unsubscribe/ADLS1Rh8hfchAu6TOVK1IiClbDDMXGYJks5qQBNrgaJpZM4I9Ifl .

Daniel Greenwald Software Engineer

+44 (0) 20 3051 8149 ext 316 dg@shadowrobot.com

Shadow Robot Company Ltd. 251 Liverpool Road, N1 1LX, UK

Registered Number 3308007 (England & Wales)