search

moveit / moveit_ros

THIS REPO HAS MOVED TO https://github.com/ros-planning/moveit
70 stars 118 forks source link

Modifications for warehouse_ros refactor #699

Closed davetcoleman closed 8 years ago

davetcoleman commented 8 years ago

Rebase https://github.com/ros-planning/moveit_ros/pull/607 with latest jade-devel, along with small fix for a new file that was added since the original PR was created last August. Great work @TheBrewCrew

Required for https://github.com/ros-planning/moveit_ros/issues/695

@mikeferguson

130s commented 8 years ago

Travis job is failing because it tries to build moveit_ros (yes this repo itself) from source from jade-devel branch.

davetcoleman commented 8 years ago

@130s so there is a bug in the .travis.yml script? should we switch to industrial_ci?

rhaschke commented 8 years ago

Simply looks like the file database_connection.h wasn't committed:

In file included from /home/travis/ros/ws_moveit/src/moveit_ros/warehouse/warehouse/src/moveit_message_storage.cpp:37:0:
/home/travis/ros/ws_moveit/src/moveit_ros/warehouse/warehouse/include/moveit/warehouse/moveit_message_storage.h:40:47: fatal error: warehouse_ros/database_connection.h: No such file or directory
 #include <warehouse_ros/database_connection.h>

The travis.yml is fine.

davetcoleman commented 8 years ago

it builds fine locally and in my Docker containers though

rhaschke commented 8 years ago

Probably you have this include file locally, but missed to submit it. When I checkout this PR, I don't see this file.

davetcoleman commented 8 years ago

The file exists... https://github.com/ros-planning/warehouse_ros/blob/jade-devel/include/warehouse_ros/database_connection.h

I'll look into this further later, I've been focusing on an industrial_ci bug today in moveit_core

davetcoleman commented 8 years ago

This passes using new CI script. Ready to merge.

rhaschke commented 8 years ago

+1

v4hn commented 8 years ago

Thanks for your work!