search

moveit / moveit_ros

THIS REPO HAS MOVED TO https://github.com/ros-planning/moveit
69 stars 118 forks source link

[moveit_ros_visualization] joy: Clean installation rule (addresses #638) #703

Closed 130s closed 7 years ago

130s commented 8 years ago

Following a document about installation of Python script and module strictly as a cleaner solution to #638. See also an answer.

130s commented 8 years ago

Locally confirmed this works. Travis passed too.

This breaks existing user applications, but until https://github.com/ros-planning/moveit_ros/pull/691 that was recently merged (the tutorial of how to use it wasn't uploaded either on to moveit website until recently), joy node wasn't functioning from DEBs, so I assume there haven't been many users yet.

v4hn commented 8 years ago

+1 to merge this into indigo-devel and jade-devel. I also do not believe renaming the node is a problem.

davetcoleman commented 8 years ago

Does this change the roslaunch file joystick_control.launch? Because you are dropping .py from the node name? Is there a better work around for backwards compatibility, since we can't change the roslaunch files that have been created specifically for robots via the setup assistant? e.g. keep the node name moveit_joy.py and rename the other file in the PR moveit_joy_planning.py?

@garaemon as the original author how do you feel about this change?

v4hn commented 7 years ago

As pointed out, renaming the script would dictate a change to a *_moveit_config launch file. This is not an option for this change. Closing the request.