search

moveit / moveit_ros

THIS REPO HAS MOVED TO https://github.com/ros-planning/moveit
70 stars 118 forks source link

Stop execution on motion planning rviz plugin #709

Closed wkentaro closed 8 years ago

wkentaro commented 8 years ago

moveit_motion_planning_rviz_plugin_stop_button

davetcoleman commented 8 years ago

Sounds cool - can you provide a screenshot of the GUI change?

wkentaro commented 8 years ago

I added a GIF.

wkentaro commented 8 years ago

Oops, I sent the wip code. Fixed.

davetcoleman commented 8 years ago

+1, looks great!

rhaschke commented 8 years ago

Nice feature. Have a look at the inline comments.

rhaschke commented 8 years ago

Hm. While your recent code will fix the enabling of the stop button, I think the code is rather complicated. Why do you need to use asynchronous execution at all? The execute() and move() calls were already executed within a separate thread of rviz. Hence, there is no problem to synchronously wait for their end. Did you tried that?

wkentaro commented 8 years ago

Did you tried that?

Yeah, I have tried move() calls and tried to pushing the stop button, but the joint trajectory action could not be canceled.

rhaschke commented 8 years ago

If you agree, please close this PR in favor of #713.

rhaschke commented 8 years ago

Closed in favor of #713.