search

moveit / moveit_ros

THIS REPO HAS MOVED TO https://github.com/ros-planning/moveit
70 stars 118 forks source link

Switch to std::shared_ptr for FCL and octomap types. #726

Closed de-vri-es closed 8 years ago

de-vri-es commented 8 years ago

More boost::shared_ptr to std::shared_ptr conversions for FCL 0.5.

Needs ros-planning/geometric_shapes#47 and ros-planning/moveit_core#316

See also ros-planning/moveit_core#315

davetcoleman commented 8 years ago

This worked for me - now I'm getting an error in moveit_fake_controller_manager ;-)

de-vri-es commented 8 years ago

Interesting, that passed for me without problems iirc. I'm currently looking at the unit tests, because those don't compile even in moveit_core now. Will have a close look at moveit_fake_controller_manager after those.

de-vri-es commented 8 years ago

@davetcoleman: I found the issue with moveit_fake_controller_manager. C++11 is not enabled there. I didn't notice it myself because I use gcc 6 which defaults to C++14.

Could you (or someone else) make a kinetic-devel branch for moveit_plugins?

davetcoleman commented 8 years ago

I didn't notice it myself because I use gcc 6 which defaults to C++14

Have you ever used Docker? I'm going to setup one for all these PRs so we can verify in a clean environment that they work

Could you (or someone else) make a kinetic-devel branch for moveit_plugins?

Done

de-vri-es commented 8 years ago

Have you ever used Docker? I'm going to setup one for all these PRs so we can verify in a clean environment that they work

Yes. we're using docker for a CI server at the office to also test on Ubuntu. I don't have it set-up at home though. I should do that at some point :)

Done

Awesome, thanks.

davetcoleman commented 8 years ago

The set of C++11 changes required for FCL 0.5 discussed here are now passing in Kinetic in this test environment. Note that the kinetic branch will continue not to work without installing from source the latest Octomap and FCL, but these will soon be released. Merging all related PRs.