search

moveit / moveit_ros

THIS REPO HAS MOVED TO https://github.com/ros-planning/moveit
69 stars 118 forks source link

Update moveit_ros metapackage cmakelists #732

Closed jonbinney closed 7 years ago

jonbinney commented 7 years ago

Without this small change, catkin thinks that the CMakeLists is nonstandard:

WARNING: The CMakeLists.txt of the metapackage 'moveit_ros' contains non standard content. Use the content of the following file instead: /home/jbinney/ws/transplanting/build/catkin_generated/metapackages/moveit_ros/CMakeLists.txt

Which causes catkin to treat the workspace as "NONHOMOGENOUS" and leads to 

CMake Error at /opt/ros/kinetic/share/catkin/cmake/catkin_workspace.cmake:95 (message):
  This workspace contains non-catkin packages in it, and catkin cannot build
  a non-homogeneous workspace without isolation.  Try the
  'catkin_make_isolated' command instead.
Call Stack (most recent call first):
  CMakeLists.txt:63 (catkin_workspace)

-- Configuring incomplete, errors occurred!
See also "/home/jbinney/ws/transplanting/build/CMakeFiles/CMakeOutput.log".
See also "/home/jbinney/ws/transplanting/build/CMakeFiles/CMakeError.log".
Invoking "cmake" failed
davetcoleman commented 7 years ago

Since we already switched the other packages this looks good

Note that Travis will not pass for any of the kinetic branches until fcl is fixed.

v4hn commented 7 years ago

I tend to call this a bug in catkin... But as the patch is trivial, this is no problem here. Thanks @jonbinney !

On Thu, Jul 28, 2016 at 07:18:16PM -0700, Dave Coleman wrote:

Since we already switched the other packages this looks good

Note that Travis will not pass for any of the kinetic branches until fcl is fixed.

You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/ros-planning/moveit_ros/pull/732#issuecomment-236078032