search

moveit / moveit_ros

THIS REPO HAS MOVED TO https://github.com/ros-planning/moveit
70 stars 118 forks source link

launching move_group can take very long if collision geometry is very… #741

Closed anderwm closed 8 years ago

anderwm commented 8 years ago

… complicated, this commit adds a warning for that case. If the excludeRobotLinksFromOctree() is takes longer than 30 seconds this prints a one time warning.

v4hn commented 8 years ago

+1 to have this in indigo, jade and kinetic in case the tests succeed

davetcoleman commented 8 years ago

@anderwm can you open a PR for jade also?

btw I noticed you opened multiple PRs for this to be reviewed at once... was there a particular reason for this? I'd only open one in the future then once its approved open the others.

Thanks for improving user feedback within moveit through warnings!

v4hn commented 8 years ago

On Thu, Aug 04, 2016 at 04:37:53PM -0700, Dave Coleman wrote:

btw I noticed you opened multiple PRs for this to be reviewed at once... was there a particular reason for this?

I asked him to, so this 1. gets tested with a working test suite (kinetic was broken) and 2. is backported to indigo & jade without anyone forgetting about it.