moveit / moveit_ros

THIS REPO HAS MOVED TO https://github.com/ros-planning/moveit
69 stars 118 forks source link

Reverting Planning Scene Updates #742

Closed v4hn closed 7 years ago

v4hn commented 7 years ago

These were merged prematurely. At least two severe issues appeared because of these patchsets and a basic assumption about the working of AsyncSpinner turned out to be wrong.

@rhaschke I hope we can still get these issues addressed soon in the merged repository. Thanks for your work on them! Enjoy your vacation :)

davetcoleman commented 7 years ago

@dornhege do you have time today to verify this before tomorrows migration? otherwise it looks good to me.

davetcoleman commented 7 years ago

@v4hn can you cherry-pick it to jade/kinetic?

dornhege commented 7 years ago

Unfortunately I was in the wrong time zone. For ease of mind, I just rebuild this and everything works fine!

v4hn commented 7 years ago

for the record: the relevant changes were never merged in jade & kinetic, so there was no reason to cherry-pick them.