Values are now read from kinematics.yaml correctly.

moveit / moveit_setup_assistant

THIS REPO HAS MOVED TO https://github.com/ros-planning/moveit

8 stars 20 forks source link

Values are now read from kinematics.yaml correctly. #100

Closed jim-rothrock closed 9 years ago

jim-rothrock commented 9 years ago

Fixes issue https://github.com/ros-planning/moveit_setup_assistant/issues/99. I wanted to confine the changes to findValue(), but everything I tried caused findValue() to crash.

mikeferguson commented 9 years ago

+1. One suggestion above for readability/maintainability.

I guess the one question I have is (and this isn't directed at you Jim, it's directed at everyone): when can we drop support for the old yaml-cpp API? In theory, all of the supported platforms for Indigo are now yaml-cpp 0.5.

jim-rothrock commented 9 years ago

Simplified the changes.

davetcoleman commented 9 years ago

I just built and loaded an old config package, everything works on 14.04. Thanks!