search

moveit / moveit_setup_assistant

THIS REPO HAS MOVED TO https://github.com/ros-planning/moveit
8 stars 20 forks source link

write float numbers always in POSIX format #123

Closed v4hn closed 8 years ago

v4hn commented 8 years ago

It makes me feel quite sad nobody provided the two-line fix for this issue over the course of 3 years. One of the very first things I heard about MoveIt! in 2013 was @mintar ranting about MoveIt failing to write locale-invariant config files...

Please cherry-pick this to jade and kinetic.

Fixes #51, #107

mintar commented 8 years ago

I wasn't ranting, saying "yeah, this is one of those things somebody should fix some day"... thanks for doing that!

I remember having a conversation about this with @davetcoleman at ROSCon 2012. Our agreement was that if we Germans agree to use the "." instead of the "," as a decimal point, the Americans will use SI units instead of Imperial units. I still think that would make everyones life much easier. ;-)

v4hn commented 8 years ago

On Thu, Jul 28, 2016 at 06:03:00AM -0700, Martin Günther wrote:

I wasn't ranting, saying "yeah, this is one of those things somebody should fix some day"... thanks for doing that!

Ok, maybe "ranting" is too hard a word. :) But you were a bit frustrated with the (over)complicated structure of MoveIt and many minor bugs, this being one of them.

Well, it actually became quite a bit more easy to use MoveIt in the last few month, I would say!

I remember having a conversation about this with @davetcoleman at ROSCon 2012. Our agreement was that if we Germans agree to use the "." instead of the "," as a decimal point, the Americans will use SI units instead of Imperial units. I still think that would make everyones life much easier. ;-)

At least throughout ROS this is the case now, isn't it? :-)

v4hn commented 8 years ago

cherry-picked to jade and kinetic

davetcoleman commented 8 years ago

I've since changed my mind, I think MoveIt! should plan in inches.