moveit / moveit_setup_assistant

THIS REPO HAS MOVED TO https://github.com/ros-planning/moveit
8 stars 20 forks source link

Generate joint_limits.yaml using ordered joints #80

Closed davetcoleman closed 10 years ago

davetcoleman commented 10 years ago

The std::sort structure was storing pointers, so I believe it was populating its binary search trees based on memory address locations, I've added a custom comparator that instead compares the joint model's names, ensureing alphabetical ordering.

Fix for https://github.com/ros-planning/moveit_setup_assistant/issues/53

isucan commented 10 years ago

+1

hersh commented 10 years ago

I just ran this and the joints in joint_limits.yaml were still not in alphabetical order. Does this work for you?

hersh commented 10 years ago

oop, hold on, ran with wrong ROS_PACKAGE_PATH...

hersh commented 10 years ago

ok, works fine. :)