search

moveit / moveit_setup_assistant

THIS REPO HAS MOVED TO https://github.com/ros-planning/moveit
8 stars 20 forks source link

Added planner specific parameters to ompl_planning.yaml emitter. #85

Closed drchrislewis closed 10 years ago

drchrislewis commented 10 years ago

Each parameter is set to current defaults. This is fragile, as defaults may change. However, yaml makes it difficult to provide correct syntax for parameters as comments which would have been preferable.

Each parameter also has comments which help users understand what it means.

isucan commented 10 years ago

+1, assuming the build error is fixed.

drchrislewis commented 10 years ago

please explain both the +1, and the build error. My intuition says +1 is same as kudos.

It seems to build, run, and the resulting file works with the GUI. The main issue I have is making sure the parameter names an default values I provide are identical to those in the source of ompl. I tried not to change the default behavior. Toward this goal I would have liked to have generated commented parameters like:

range: 0.0 # Maximum distance from current graph to grow ....

However, yaml's emitter did not want to do that... at all.

On Thu, May 15, 2014 at 11:52 AM, Ioan A Sucan notifications@github.comwrote:

+1, assuming the build error is fixed.

— Reply to this email directly or view it on GitHubhttps://github.com/ros-planning/moveit_setup_assistant/pull/85#issuecomment-43235624 .

isucan commented 10 years ago

+1 means that i agree this should be merged. the Travis build that run for your previous version had failed (I did not check why), but it passes now. I will let someone else complete the merge, as this is a config change, and more eyes are better :)

davetcoleman commented 10 years ago

Looks good