search

moveit / moveit_task_constructor

A hierarchical multi-stage manipulation planner
https://moveit.github.io/moveit_task_constructor
BSD 3-Clause "New" or "Revised" License
183 stars 152 forks source link

Update API: JumpThreshold -> CartesianPrecision #611

Closed rhaschke closed 2 months ago

rhaschke commented 2 months ago

This should be merged only after the next MoveIt release.

codecov-commenter commented 2 months ago

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 76.19048% with 5 lines in your changes missing coverage. Please review.

Project coverage is 57.63%. Comparing base (6b0f2c8) to head (55b65e0). Report is 41 commits behind head on master.

Files with missing lines Patch % Lines
core/python/bindings/src/solvers.cpp 68.75% 5 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #611 +/- ## ========================================== - Coverage 58.82% 57.63% -1.19% ========================================== Files 91 132 +41 Lines 8623 10687 +2064 Branches 0 962 +962 ========================================== + Hits 5072 6158 +1086 - Misses 3551 4482 +931 - Partials 0 47 +47 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

v4hn commented 2 months ago

Thanks for addressing the feedback. :+1:

Do you really want to keep this lying here until a new moveit release? I know we went for supporting released and master branch of moveit in the past, but I'm not sure I see the need for it. Of course we should hold a new release tag until moveit is released as well.

What's your plan for this? I would merge here if not for your statement above.

rhaschke commented 2 months ago

What's your plan for this? I would merge here if not for your statement above.

I prefer to have a MoveIt release. Otherwise we enforce people to build from source. I am happy to cut a new MoveIt release the next days, if there are no objections.