moveit / moveit_visual_tools

Helper functions for displaying and debugging MoveIt! data in Rviz via published markers
BSD 3-Clause "New" or "Revised" License
151 stars 102 forks source link

Fixed deprecated call to PlanningSceneMonitor's constructor #108

Closed stephanie-eng closed 2 years ago

stephanie-eng commented 2 years ago

Fixes the warnings when building from #107

henningkayser commented 2 years ago

@stephanie-eng what's the state of this PR? seems like there are still some issues to resolve

markusbuchholz commented 2 years ago

I have just installed ROS2 foxy (on Ubuntu 20.04 also installed just before )and unfortunately I struggled with regarding issue. In order to go further I just commend the line so I could complete build. This is only information since I do not not yet how important described issue is. Thank you!

vatanaksoytezer commented 2 years ago

Hello @markusbuchholz thanks for reporting! Are you using the foxy branch (https://github.com/ros-planning/moveit_visual_tools/tree/foxy) of this repository? I can't reproduce what you are seeing neither in my local setup or in CI (https://github.com/ros-planning/moveit_visual_tools/runs/4291381993?check_suite_focus=true).

markusbuchholz commented 2 years ago

Hello @vatanaksoytezer . Yes I installed great foxy however I can install the latest version. Brilliant Moveit 2 I installed just after the foxy and Ubuntu 20.04. (fresh systems). As I mentioned my issue can be handled as information only since I could complete building OK (however by isolating/commented discussing line of code) . Not sure about the latest ROS2. I suppose it is OK. Thank you!