search

moveit / moveit_visual_tools

Helper functions for displaying and debugging MoveIt! data in Rviz via published markers
BSD 3-Clause "New" or "Revised" License
151 stars 102 forks source link

getEEParentLink not defined in visual_tools.h #3

Closed ghost closed 10 years ago

ghost commented 10 years ago

Hi, I am trying to use your visual tools in moveit but I noticed that the getEEParentLink() function is not defined in VisualTools class. Is there a reason for this? Thank you.

Sonny

davetcoleman commented 10 years ago

Hmmm, I don't recall the history of this function but certainly it is a mistake that I didn't delete it. Do you need it implemented? Otherwise I will remove it. Thanks for pointing this out.

ghost commented 10 years ago

I am using your baxter_cpp package (may be an old version) that calls this function but I removed this part of code as I don't needed it. So it's all right. By the way, thank you for your job!

davetcoleman commented 10 years ago

Looking into it more, visual_tools is no longer pinned to just one end effector, so this function should be removed. I'll remove it from the baxter repo too https://github.com/davetcoleman/moveit_visual_tools/commit/7b1b712ca8dc7e799a312322d97918f06d6add0f

davetcoleman commented 10 years ago

This is a bad hack, but I don't have time to work on Baxter right now: https://github.com/davetcoleman/baxter_cpp/commit/6510a02241992c8f868be538789f9e11e2b53948