fix end-effectors containing mimic joints v2

moveit / moveit_visual_tools

Helper functions for displaying and debugging MoveIt! data in Rviz via published markers

BSD 3-Clause "New" or "Revised" License

151 stars 102 forks source link

fix end-effectors containing mimic joints v2 #84

Closed simonschmeisser closed 3 years ago

simonschmeisser commented 3 years ago

this is an iteration on #83 based on the new function JointModelGroup::setJointGroupActivePositions introduced by https://github.com/ros-planning/moveit/pull/2456

It fixes #82

simonschmeisser commented 3 years ago

this still fails as the changes in MoveIt need to be synced to noetic-devel?

davetcoleman commented 3 years ago

That sounds right... ive just retriggered the builds to see if that has been synced by now.

simonschmeisser commented 3 years ago

friendly ping

v4hn commented 3 years ago

Thank you for the patch and the ping :+1:

simonschmeisser commented 3 years ago

I somehow ended up with a debug build of MoveIt and running master of this and my assert for the group size in setJointGroupPositions actually triggered :100: Thanks for merging!