search

moveit / moveit_visual_tools

Helper functions for displaying and debugging MoveIt! data in Rviz via published markers
BSD 3-Clause "New" or "Revised" License
151 stars 102 forks source link

Port to ros2 #92

Closed vatanaksoytezer closed 3 years ago

vatanaksoytezer commented 3 years ago

This is currently blocked by: https://github.com/PickNikRobotics/rviz_visual_tools/pull/185 . With that merged this should work without any problems.

JafarAbdi commented 3 years ago

This is currently blocked by: PickNikRobotics/rviz_visual_tools#185 . With that merged this should work without any problems.

I merged it

vatanaksoytezer commented 3 years ago

Sorry, for forgetting this I will also need a ROS2 branch on https://github.com/PickNikRobotics/graph_msgs and send a PR port right there as well

vatanaksoytezer commented 3 years ago

Looks pretty clean so far Were you able to get all of the demo work as expected? I'll probably test this later today.

@henningkayser Yes! Demo should work as expected. Thanks a lot for the detailed review, that is really helpful for me. I will send the fixes in Sunday when I get back home.

vatanaksoytezer commented 3 years ago

One note for demo you would need the current foxy-devel branch of rviz_visual_tools and https://github.com/PickNikRobotics/graph_msgs/pull/5. And it should work. Let me know if something unexpected happens.

vatanaksoytezer commented 3 years ago

I've adressed most issues from the review. Just had trouble with one export (see comment above). @henningkayser feel free to add more comments to my answers.

vatanaksoytezer commented 3 years ago

Fixed the export issue, addressed your last review. This should be (mostly) ready to merge after you test it @henningkayser. Thanks again for such a detailed review, I really appreciate it!

AdamPettinger commented 3 years ago

I've built and tested this locally. The demo runs well, and I was able to use moveit_visual_tools in another package successfully (but not used as in depth as the demo of course)

vatanaksoytezer commented 3 years ago

@henningkayser @JafarAbdi is there anything else you would like me to address?