moveit / panda_moveit_config

The Panda robot is the flagship MoveIt integration robot
http://docs.ros.org/kinetic/api/moveit_tutorials/html/
105 stars 172 forks source link

Remapping of joint_states intended? #37

Closed GnnrMrkr closed 5 years ago

GnnrMrkr commented 5 years ago

Hello!

I stumbled on the line which remaps the joint states: <remap from="/joint_states" to="/joint_states_desired" /> (l. 78 in move_group.launch)

Is this line intended? I am working with a real panda robot and was creating launch files for two different usecases. In both cases, I removed this line, as it seemed to be not only not-necessary; but also hindering, as it prevented move_group from getting the real joint states. Is this desired?

It looks like I'm not the only one who came across this (see here), so it would be great if you could look over it and check which way it should be.

Thank you!

fwalch commented 5 years ago

Some explanation for why this is required is provided in https://github.com/ros-planning/panda_moveit_config/pull/9#issuecomment-412055080. I'll try to expand on this, but in the meantime, maybe the docu can help to explain why there is a difference between measured joint states q and desired joint states q_d.

GnnrMrkr commented 5 years ago

Alright. Thanks for the clarification. Good to know that this is intended. To be honest, this is rather confusing. My issues were probably related to mixing up the joint state publishers, but I will go through my launch files once more.

Since I'm using franka_ros, I just skimmed through the part of the docu on libfranka.