Fix compilation in ROS Melodic

moveit / panda_moveit_config

The Panda robot is the flagship MoveIt integration robot

http://docs.ros.org/kinetic/api/moveit_tutorials/html/

105 stars 172 forks source link

Fix compilation in ROS Melodic #85

Closed eborghi10 closed 3 years ago

eborghi10 commented 3 years ago

This PR fixes the compilation in ROS Melodic with these two changes:

Remove unsupported adapter (default_planner_request_adapters/ResolveConstraintFrames)
Replace panda_arm_hand.urdf.xacro by panda_arm.urdf.xacro hand:=true

eborghi10 commented 3 years ago

Could you please argue, why you think the adapter FixStartStatePathConstraints is not supported? Do you mean ResolveConstraintFrames? Please refer to the change in franka_description requiring the change for URDF.

Yes, sorry I mean to write ResolveConstraintFrames since it's not available in Melodic (see here).

rhaschke commented 3 years ago

I just found the pending PR #83. Will merge that one.

rickstaa commented 3 years ago

@eborghi10 I think this pull request can be closed since #83 has been merged.

eborghi10 commented 3 years ago

Sure, let's close it.