Closed AndyZe closed 1 year ago
I think galactic-testing is failing because this usage of std::to_chars requires C++17
You need a pretty recent gcc version for floating point support in std::to_char
Alright, thanks. What do you recommend to do here @simonschmeisser ?
First I'd verify the gcc version as the source of the problem, what does galactic mean in terms of Ubuntu? Then probably copy paste the helper function from MoveIt core helpers
Base: 67.83% // Head: 67.09% // Decreases project coverage by -0.74%
:warning:
Coverage data is based on head (
4bb945b
) compared to base (91d7db8
). Patch coverage: 0.00% of modified lines in pull request are covered.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
So it seems a very ugly hack (by actually switching the locale, which is global in c, temporarily) to support floating points in std::from_char
was added for gcc 11.1.0, Ubuntu 20.04 defaults to 9.4.0. Proper support seems to have been implemented by now but is not actually released yet ( https://github.com/gcc-mirror/gcc/commits/master/libstdc%2B%2B-v3/src/c%2B%2B17/floating_from_chars.cc ).
Motivated by these MoveIt and ros2_control issues:
https://github.com/ros-planning/moveit2/issues/1882
https://github.com/ros-controls/ros2_control/pull/921/files