moveit / srdfdom

Semantic Robot Description Format
BSD 3-Clause "New" or "Revised" License
13 stars 68 forks source link

Refactor joint properties data structure (#110) #111

Closed scchow closed 1 year ago

scchow commented 1 year ago

This PR addresses #110 for Noetic:

After doing incorporating these changes, I realized that this would significantly change functionality in the following ways:

As a result, if this PR gets merged, I will need to update my PR in MoveIt! (https://github.com/ros-planning/moveit/pull/3359) to account for the modified data structures here.

Since the backport that I did for ROS1 is relatively new, merging this shouldn't cause many problems, as I doubt anyone else has started using the features I backported 2 weeks ago.

However, we should be careful about doing the same for ROS2, since it will likely break things in MoveIt2 (such as the same test in MoveIt2 here and as well as anyone else who were relying on the original joint properties data structure/function signatures).

I can definitely work on a similar PR for ROS2, but wanted to get your thoughts first.

Cheers!

rhaschke commented 1 year ago

Please adapt your MoveIt PR accordingly.

rhaschke commented 1 year ago

Thanks for cleaning this up!

scchow commented 1 year ago

Thanks for the helpful comments! Good call on using the descriptive aliases.

I'll put together a similar patch for the ROS2 branch if I can find some time this/next week.