moveit / srdfdom

Semantic Robot Description Format
BSD 3-Clause "New" or "Revised" License
12 stars 68 forks source link

Use urdf::*SharedPtr instead of boost::shared_ptr #19

Closed jspricke closed 8 years ago

jspricke commented 8 years ago

urdfdom_headers uses C++ std::shared_ptr. As it exports it as custom *SharedPtr type, we can use the to stay compatible.

v4hn commented 8 years ago

Heya! Great to see you are still cleaning up :-)

According to the test results, it looks like this type has been added rather recently and is not available in indigo and jade yet. So we can't merge that into indigo (as you proposed).

On Fri, Sep 09, 2016 at 03:17:59AM -0700, Jochen Sprickerhof wrote:

urdfdom_headers uses C++ std::shared_ptr. As it exports it as custom *SharedPtr type, we can use the to stay compatible. You can view, comment on, or merge this pull request online at:

https://github.com/ros-planning/srdfdom/pull/19

-- Commit Summary --

  • Use urdf::*ShredPtr instead of boost::shared_ptr

-- File Changes --

M src/model.cpp (2)

-- Patch Links --

https://github.com/ros-planning/srdfdom/pull/19.patch https://github.com/ros-planning/srdfdom/pull/19.diff

You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/ros-planning/srdfdom/pull/19

davetcoleman commented 8 years ago

Earlier today I created a kinetic branch that this PR would be ideal for. I can create a jade branch if needed also

rhaschke commented 8 years ago

This is already included in #18 and #21.