search

moveit / srdfdom

Semantic Robot Description Format
BSD 3-Clause "New" or "Revised" License
12 stars 68 forks source link

ROS-M: Use std::shared_ptr #33

Closed davetcoleman closed 6 years ago

davetcoleman commented 7 years ago

Currently this repo has:

typedef boost::shared_ptr<Model> ModelSharedPtr;
typedef boost::shared_ptr<const Model> ModelConstSharedPtr;

Unlike the rest of moveit

v4hn commented 7 years ago

could we still change that in -L already?

davetcoleman commented 7 years ago

I don't think we can change this in Lunar until we decide we want to branch all of MoveIt! to Lunar, which I'm ok with doing now that we've discontinued Jade. Let's discuss at a maintainer meeting.

v4hn commented 7 years ago

Hm, did we forgot to talk about this in the meeting?

davetcoleman commented 7 years ago

It was in my notes for the meeting and I overlooked it, yea. I don't think this nit-picky cleanup is motivation to branch for L yet, but I certainly hope to see this in M.

rhaschke commented 6 years ago

Resolved in #36.