moveit / srdfdom

Semantic Robot Description Format
BSD 3-Clause "New" or "Revised" License
13 stars 68 forks source link

Resolves #33: Remove Boost, use C++11 #36

Closed IanTheEngineer closed 6 years ago

IanTheEngineer commented 6 years ago

It may make sense to branch to melodic-devel prior to adding this commit.

rhaschke commented 6 years ago

... or just move the file to src/ to avoid installing it

I prefer this as it facilitates later reuse in another context.

rhaschke commented 6 years ago

Hi @IanTheEngineer, I'm wondering why you want to get rid of boost::trim at all? I totally agree that it makes sense to switch from boost::pointers to std::pointers. However, why should we not re-use other boost utility functions? I don't see the point of inserting header-only code (like trim) all around, instead of using, well-maintained boost code, also header-only. @v4hn, @davetcoleman What should be our policy regarding boost code?

IanTheEngineer commented 6 years ago

@rhaschke I don't have a particularly strong opinion on using boost::trim or not. The goal was just to use the tools afforded by C++11 where possible. These lambdas are pretty straightforward replacements for trim, but if we decide to leave boost as a build dependency just for trim, that's entirely acceptable.

IanTheEngineer commented 6 years ago

@rhaschke if things looks good, I can squash everything down into one commit.

davetcoleman commented 6 years ago

I agree boost is preferred over custom code, but should be replaced where possible by std

Thanks @IanTheEngineer !

v4hn commented 6 years ago

I think everyone agrees here already. If Boost offers functions that simplify our code base, then feel free to use them. There is no particular reason to remove them either, unless the standard offers equivalent solutions.