search

moveit / srdfdom

Semantic Robot Description Format
BSD 3-Clause "New" or "Revised" License
13 stars 68 forks source link

Change log{Error,Warn} -> CONSOLE_BRIDGE_log{Error,Warn} #37

Closed clalancette closed 6 years ago

clalancette commented 6 years ago

log{Error,Warn} were deprecated and removed in Melodic. Switch to the supported CONSOLE_BRDIGE_log{Error,Warn}.

Signed-off-by: Chris Lalancette clalancette@openrobotics.org

I'll note that this can also be pushed to the kinetic-devel branch, since the CONSOLE_BRIDGE macros exist there as well.

rhaschke commented 6 years ago

Thanks a lot!

clalancette commented 6 years ago

When you get a chance, a new release into Melodic should hopefully make the buildfarm happy. Thanks.

rhaschke commented 6 years ago

@130s, can you take care of the release or grant permissions to me?

130s commented 6 years ago

I'm afraid I don't have adimn right. @wjwwood could you?

mikaelarguedas commented 6 years ago

@rhaschke added as collaborator to https://github.com/ros-gbp/srdfdom-release

clalancette commented 6 years ago

@130s , @rhaschke , would you mind doing another release now so we can get this compiling in Melodic? Thanks!

rhaschke commented 6 years ago

Done: https://github.com/ros/rosdistro/pull/17600

clalancette commented 6 years ago

Fantastic, looks like it is happier now. Thanks!