search

moveit / srdfdom

Semantic Robot Description Format
BSD 3-Clause "New" or "Revised" License
13 stars 68 forks source link

Remove non-exist ROS2 dependency #53

Closed pbeeson closed 4 years ago

pbeeson commented 4 years ago

There is no urdfdom_py in ROS2, so these depends hinder rosdep install usage, and seem unnecessary for srdfdom to compile and run in ROS2.

davetcoleman commented 4 years ago

Is there an issue or someone working on releasing urdfdom_py to ROS2?

henningkayser commented 4 years ago

Is there an issue or someone working on releasing urdfdom_py to ROS2?

I'm not aware of that. Since we are planning to release all dependencies we maintain, we should look into this.

pbeeson commented 4 years ago

urdfdom_py is required by this package

I guess I don't understand why you say this since I have no urdfdom_py anywhere on my machine, and srdfdom for ros2 compiles and installs with no issue.

henningkayser commented 4 years ago

urdfdom_py is required by this package

I guess I don't understand why you say this since I have no urdfdom_py anywhere on my machine, and srdfdom for ros2 compiles and installs with no issue.

It's required for https://github.com/ros-planning/srdfdom/blob/ros2/src/srdfdom/srdf.py, but you're right, it's not a strict build dependency

pbeeson commented 4 years ago

OK if I close this?