search

moveit / srdfdom

Semantic Robot Description Format
BSD 3-Clause "New" or "Revised" License
13 stars 68 forks source link

Fix Windows DLL install location #98

Closed Ace314159 closed 2 years ago

Ace314159 commented 2 years ago

91 changed the installation location of the DLL from the lib folder to the bin folder, but it was changed back to the lib folder in #96.

The DLL needs to be installed in the bin folder because only the bin folder is searched when looking for DLLs, not the lib folder. This same pattern of installing the DLL to the bin folder is also done in MoveIt2. Here is an example.

codecov[bot] commented 2 years ago

Codecov Report

Merging #98 (4d117c2) into ros2 (dd742a0) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             ros2      #98   +/-   ##
=======================================
  Coverage   68.21%   68.21%           
=======================================
  Files           3        3           
  Lines         607      607           
=======================================
  Hits          414      414           
  Misses        193      193

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update fa48a0a...4d117c2. Read the comment docs.