Open andygolay opened 2 weeks ago
Maybe you could use features::on_new_epoch(&framework_signer);
instead of aptos_governance::reconfigure(framework_signer);
Catching up here, wouldn't on_new_epoch
still not work as there is only ever one epoch on movement testnet. The epoch would never change.
Looks like it worked π
on_new_epoch
sets the flag as if there's a new epoch.
Do you think this issue should stay open or is it already known @andyjsbell ?
Good. This will depend if this is by design so maybe @l-monninger or @mzabaluev can chip in on this?
π Bug
Because Suzuka epoch is fixed at 1, functions that rely on
aptos_governance::reconfigure
won't work.For example this script to enable feature flags:
To reproduce
Run the above script. You'll see the feature flag in
features::PendingFeatures
.Expected Behavior
We need some way to do governance without the epoch change. Perhaps
reconfiguration::reconfigure
could advance to the next block instead, so that governance proposals are enacted on next block, rather than next epoch? This would require input from @mzabaluev / @l-monninger others who are more familiar with the inner workings for the repository, as far as what side effects or subtle issues that change might entail.System information
Additional context
This is blocking client integration tests with the atomic bridge framework modules, because those modules are feature flagged out.