movementlabsxyz / movement

The Movement Network is a Move-based L2 on Ethereum.
Apache License 2.0
50 stars 48 forks source link

Remove ad-hoc JSON formatting in sequencer blobs #182

Closed mzabaluev closed 1 week ago

mzabaluev commented 1 month ago

In #171, sequence numbers are introduced in a little kludgy way, by imposing JSON encoding on a bytes field of a protobuf message. Move these values to be first-class fields of the protobuf message instead.

_Originally posted by @mzabaluev in https://github.com/movementlabsxyz/movement/pull/171#discussion_r1672390762_

andyjsbell commented 1 month ago

@mzabaluev can this be closed?

mzabaluev commented 1 month ago

@andyjsbell this is resolved by #253, which is not merged yet.

mzabaluev commented 1 week ago

Done in #299.