search

movementlabsxyz / movement

The Movement Network is a Move-based L2 on Ethereum.
Apache License 2.0
74 stars 61 forks source link

Factor indexer support out of maptos-opt-executor #241

Open mzabaluev opened 3 months ago

mzabaluev commented 3 months ago

Is your feature request related to a problem? Please describe. The support for the indexer service was added to maptos-opt-executor. This adds significantly to the dependencies, including some native dependencies like libpq, which may be undesirable for SDK crate users that need just the executor protocol unit.

Describe the solution you'd like Consider moving the indexer service into a separate micro-crate with its own dependencies.

Describe alternatives you've considered If not possible to make a clean split, consider feature-gating the indexer support.

Additional context cargo tree -p maptos-opt-executor before and after #210 got merged into main.

The current implementation of the indexer shares the API context, the database connection, and bits of configuration with the executor.

musitdev commented 2 months ago

The indexer service has been removed from Suzuka executor and moved to a separate service that use gRpc indexer entry point of the Suzuka node to get notified of new transactions. See PR #295 #431 #436

musitdev commented 2 months ago

Need an e2e test in production env with current Suzuka node Testnet DB to validate the initial dump of the indexer DB.