search

movementlabsxyz / movement

The Movement Network is a Move-based L2 on Ethereum.
Apache License 2.0
57 stars 54 forks source link

MTO-1 Lack of Events Emit #453

Open SA124 opened 1 month ago

SA124 commented 1 month ago

MTO-1 Lack of Events Emit Auditor: Movebit Code: MCR Settlement Contract Severity: Informational Status: Pending Code Location: protocol-units/settlement/mcr/contracts/src/token/base/MintableToken.sol#51

Descriptions: The contract lacks appropriate events for monitoring grantMinterRole() operations, which could make it difficult to track sensitive actions or detect potential issues.

Suggestion: It is recommended to emit events for the those function.

l-monninger commented 2 weeks ago

This would need to be fixed if we intend to use the MintableToken at centralized launch.