movementlabsxyz / movement

The Movement Network is a Move-based L2 on Ethereum.
Apache License 2.0
84 stars 68 forks source link

Channel infinitely growing with transactions #492

Closed SA124 closed 2 months ago

SA124 commented 3 months ago

Severity:[LOW] Auditor: Halborn Code: Suzuka

Channel infinitely growing with transactions The Suzuka full node creates a channel that is only used by the tick transaction pipe function, that sends each processed transaction, leading to the channel increasing in size: protocol-units/execution/opt-executor/src/executor/transaction_pipe.rs#L79 Channel with no consumer created in networks/suzuka/suzuka-full-node/src/partial.rs#L304

l-monninger commented 2 months ago

I believe this is a quirk of being in between two approaches at the audited commit height. It no longer exists as such.