search

movementlabsxyz / movement

The Movement Network is a Move-based L2 on Ethereum.
Apache License 2.0
78 stars 64 forks source link

Fix Bridge Integration Tests #607

Open 0xmovses opened 2 months ago

0xmovses commented 2 months ago

Summary

At some point some bad bridge code was merged onto main that broke our integration tests. This was not caught by CI because of our failing CI.

cargo test --test eth_movement -- --nocapture --test-threads=1:

2024-09-18T10:12:15.172587Z ERROR movement_bridge::utils: Transaction submission error: Unknown error Transaction committed on chain, but failed execution: NUMBER_OF_ARGUMENTS_MISMATCH
thread 'test_movement_client_should_successfully_call_lock_and_complete' panicked at protocol-units/bridge/integration-tests/tests/eth_movement.rs:120:14:
Failed to get bridge transfer details: CallError
FAILED

failures:

failures:
    test_movement_client_should_successfully_call_lock_and_abort
    test_movement_client_should_successfully_call_lock_and_complete

test result: FAILED. 8 passed; 2 failed; 2 ignored; 0 measured; 0 filtered out; finished in 132.13s

Requirements

Restore the tests