movementlabsxyz / movement

The Movement Network is a Move-based L2 on Ethereum.
Apache License 2.0
82 stars 65 forks source link

Bridge GraphQL Normalization #818

Closed l-monninger closed 1 week ago

l-monninger commented 2 weeks ago

Summary

Changelog

Testing

Outstanding issues

andygolay commented 1 week ago

This seems good in regards to the code normalization.

With this branch, I still get the "Failed to create indexer DB client" warning I mention in #843.

image

So far the only PR I've tested against locally where I don't get the warning, is #824

Maybe it would be good to merge #824 into main first, then rebase this against main?

l-monninger commented 1 week ago

Yes, this needs https://github.com/movementlabsxyz/movement/pull/821 to run without the indexer. I will merge it in.

andygolay commented 1 week ago

Yes, this needs #821 to run without the indexer. I will merge it in.

LGTM, I can test again locally after you merge it in.