search

movementlabsxyz / movement

The Movement Network is a Move-based L2 on Ethereum.
Apache License 2.0
77 stars 62 forks source link

Rename suzuka-full-node #848

Open rolandoesparza opened 2 days ago

rolandoesparza commented 2 days ago

Background: We want to remove reference to "suzuka" on suzuka-full-node as we have testnets with different names and infra partners are getting confused when deploying on Bardock testnet.

Options: 1) Rename suzuka-full-node to testnet-full-node 2) Rename suzuka-full-node to full-node 2) Make a copy of suzuka-full-node and rename to bardock-full-node

Priority: Urgent (P0)

bhenhsi commented 2 days ago

Option to consider: movement-full-node or mvmt-full-node

mzabaluev commented 13 hours ago

I'm leaning towards renaming suzuka to movement, but we have branding complications e.g. in explaining our project structure.

To wit, subdirectories in networks should provide different integrations to power Movement networks (understood broadly as everything that we deploy using code from this repository). So far there is only one suzuka/* family of crates, and it should be used for both testnet and mainnet (as well as any possible devnets), as naturally, crate revisions tested on the testnet eventually get released on mainnet.

What should be the branding for the integration described in that README?

l-monninger commented 13 hours ago

I agree we should not be naming different units in the actual software to reflect different versions. The original intended use of networks/ and the differing network names was to represent architecturally distinct networks composed with the procotol-units.

At one point in time, for example, we had suzuka/* and monza/* crates for an FFS and an optimistic rollup respectively.

I think movement-* is fine. We're basically moving on from the suzuka-* naming. And, since this is our flagship network, it's okay if it's eponymous.