movementlabsxyz / movement

The Movement Network is a Move-based L2 on Ethereum.
Apache License 2.0
82 stars 65 forks source link

Trusted Native Bridge #864

Closed Primata closed 3 days ago

Primata commented 4 days ago

Summary

Reduces the amount of calls on Solidity Bridge Contracts to initiate and complete Combines contracts Removes user secret sharing requirement

Changelog

Testing

fuzz test on initiateBridge fuzz test on completeBridge

Outstanding issues

Move side

0xmovses commented 3 days ago

Could you remove all the build files generated by forge.

0xmovses commented 3 days ago

conflicts

I would remove all the renaming completely from this PR as this PR just should focus on the contracts not renaming. Merge in main and accept all the changes from main.

Renaming in a seperate PR, that should resolve them all.

Primata commented 3 days ago

conflicts

I would remove all the renaming completely from this PR as this PR just should focus on the contracts not renaming. Merge in main and accept all the changes from main.

Renaming in a seperate PR, that should resolve them all.

bridge contract is already merged into a single one, can't keep the old names

0xmovses commented 3 days ago

@Primata Ok you can resolve the conflicts for the contracts then by keeping your changes, but for the rest you can accept changes from main. Anyway it's up to you how you want to resolve them, was just a suggestion as to how I'd approach it.

0xmovses commented 3 days ago

Thanks almost there just delete the broadcasts/ directory commit that as its still committing the empty dirs now.

0xmovses commented 3 days ago

tests are passing, contracts look good to me