moves-rwth / storm

A Modern Probabilistic Model Checker
https://www.stormchecker.org
GNU General Public License v3.0
127 stars 74 forks source link

Cudd installed via home-brew clash #395

Open sjunges opened 1 year ago

sjunges commented 1 year ago

If i try to make storm, i run into the following issue.

[ 39%] Building CXX object src/storm/CMakeFiles/storm.dir/abstraction/AbstractionInformation.cpp.o
...
/Users/junges/storm/src/storm/storage/dd/cudd/InternalCuddBdd.h:46:67: error: use of undeclared identifier 'cudd'; did you mean 'Cudd'?
    InternalBdd(InternalDdManager<DdType::CUDD> const* ddManager, cudd::BDD cuddBdd);
                                                                  ^~~~
                                                                  Cudd
/opt/homebrew/include/cuddObj.hh:448:7: note: 'Cudd' declared here
class Cudd {

The only way i managed to work around it so far is by uninstalling yices2 from brew as this uninstalled cudd3 from brew....

tquatmann commented 1 year ago

Would it be an option to rename resources/3rdparty/cudd-3.0.0/cplusplus/cuddObj.hh to something like resources/3rdparty/cudd-3.0.0/cplusplus/storm_cuddObj.hh ?

sjunges commented 1 year ago

Indeed, that could be one option. Another option could be to change the include dir and make sure that we have to include <storm-cudd/cplusplus/cuddObj.h>? I dont know what is better.

tquatmann commented 1 year ago

Yes, that sounds reasonable, too. I also don't know what is better 😄

sjunges commented 3 months ago

Dagstuhl agrees: storm-cudd/cplusplus/cuddObj.h is better.