search

moves-rwth / storm

A Modern Probabilistic Model Checker
https://www.stormchecker.org
GNU General Public License v3.0
135 stars 74 forks source link

Get z3 version by parsing version file #513

Closed volkm closed 5 months ago

volkm commented 6 months ago

Recently, CI builds fail because they are sometimes stuck in obtaining the z3 version. See here for an example. The problem might be due to compiling a small program with z3 in order to obtain the z3 version.

This PR obtains the z3 version by parsing the file z3_version.h instead. The old option is still present to preserve backwards compatibility to versions before this fix.

sjunges commented 6 months ago

I am fine with this, but it adds additional complexity that I would not include if this is actually not necessary?

volkm commented 6 months ago

The change is currently not needed anymore. I personally find the new way of parsing the version better than compiling a small program though. The latter can also fail due to compilation issues which are not coming from z3 (as seen when this issue was triggered).

sjunges commented 5 months ago

Do you think we need to retain the old variant as well then?

volkm commented 5 months ago

I checked and then z3 version file is present since 4.8.1. Even Ubuntu 20.04 ships with z3 version 4.8.7. So we should be fine with removing the old check.