Use some sort of `const` modifier in `STORM_LOG_ASSERT` implementation?

[linusheck]

Hi, I was just bit by a silly error where I had something with side effects in my STORM_LOG_ASSERT, which was not executed in release mode. My idea was to add something into STORM_LOG_ASSERT that ensures that there are no side effects, but this apparently cannot be done, because constexpr is actually compile-time and there is no alternative that checks for "no side effects", e.g. only const function invocations (which I know can have side effects) and their compositions with simple operators (which can of course also have side effects)

[linusheck]

ok, it seems like

• constexpr is only for compile-time, which is not adequate
• there is absolutely no way of finding out whether something has side effects in c++

[linusheck]

https://stackoverflow.com/questions/10593492/catching-assert-with-side-effects

This has a cool way of catching that the compiler knows an expression has no side-effects, but the Storm codebase is not a large legacy codebase, so this would be super overkill and it's fine as it is :)