Open tquatmann opened 2 months ago
Thanks!
Indeed, there are some API-related improvements to be made in region.h
. This will probably also affect the command line interface.
However, I suggest to do these in a separate PR as this one is already big enough.
This PR refactors the code for the region model checking in storm-pars:
RegionRefinementChecker
that is responsible for the latter.RegionSplittingStrategy
in theRegionRefinementChecker
. The strategy potentially can make use of region split estimates, which assign to each parameter a numerical value indicating how useful splitting for that parameter is.MonotonicityBackend
that manages the computation of relevant monotonicity information and the propagation to subregions.What still needs to be done is a (re-)implementation of the actual splitting strategies in
RegionRefinementChecker::getSplittingVariables
, most likely usingobtainRegionSplitEstimates
. Previously, this was done in a method called splitSmart.Also, some more extensive testing would be helpful.