moves-rwth / storm

A Modern Probabilistic Model Checker
https://www.stormchecker.org
GNU General Public License v3.0
126 stars 73 forks source link

Remove more warnings #547

Closed AlexBork closed 1 month ago

AlexBork commented 1 month ago

This removes more warnings in storm-pomdp. This includes both warnings when compiling with AppleClang on macOS using cmake option STORM_ALLWARNINGS and some unused parameter warnings occurring with GCC (as observed in the CI).

sjunges commented 1 month ago

LGTM. Many thanks for the swift action!

tquatmann commented 1 month ago

LGTM

volkm commented 1 month ago

Small note regarding the semicolon: I think the issue comes from here. Should we remove the semicolons here?

AlexBork commented 1 month ago

I would prefer to always require a semicolon, though I think just removing it there doesn't work (I did a quick test). I'll open an issue where we can potentially discuss this.