moves-rwth / storm

A Modern Probabilistic Model Checker
https://www.stormchecker.org
GNU General Public License v3.0
135 stars 74 forks source link

Soplex cmake export fixed #549

Closed sjunges closed 4 months ago

sjunges commented 4 months ago

The problem was that soplex export its location only for the release configuration and we were not handling that case.

fixes https://github.com/moves-rwth/storm/issues/358. I think it also resolves https://github.com/moves-rwth/storm/issues/364

Whether we should have additional sanity checks on the created cmake config is another question. I think it is hard to do that really well, so i would rather not do that right now.

volkm commented 4 months ago

Interesting behaviour to only export for the Release. Thanks for the fix. LGTM.