moves-rwth / storm

A Modern Probabilistic Model Checker
https://www.stormchecker.org
GNU General Public License v3.0
138 stars 75 forks source link

clangd go-to-definition goes to include files #631

Open linusheck opened 1 week ago

linusheck commented 1 week ago

If I start clangd on the automatically generated compile_commands.json and goto a definition, it will put me into

build/include/storm/solver/OptimizationDirection.h

instead of

src/storm/solver/OptimizationDirection.{h,cpp}

even though the include file is not mentioned in compile_commands.json. Sadly, we cannot find anyone else experiencing this issue anywhere on the internet.

sjunges commented 1 week ago

I don't know whether https://github.com/moves-rwth/storm/pull/602 solves it, but it may.

volkm commented 1 week ago

I think the underlying issue is that we export all header files into build/include. I have similar issues when following the includes in e.g. CLion. This might indeed be resolved after Sebastian's PR (...or not).

sjunges commented 1 week ago

I actually don't want to do this export during builds anymore, but that is not yet part of the PR.