search

moves-rwth / stormvogel

Storm for almost everyone
2 stars 0 forks source link

Setup branch protection #1

Closed YouGuessedMyName closed 2 months ago

YouGuessedMyName commented 2 months ago

To ensure our code quality remains high from the beginning, I think we should protect the master branch and require the CI to pass (and maybe also one approving review) before merging a pull request. This does make it a bit more cumbersome to make changes. What do you think?

linusheck commented 2 months ago

Agreed :) I think we should currently not require a review, so we can iterate faster until the codebase is more stable

linusheck commented 2 months ago

Done

linusheck commented 2 months ago

we discussed and will use pre-commit for now