search

movim / movim_ynh

[UNMAINTAINED -> go to YunoHost-Apps/movim_ynh]
https://github.com/YunoHost-Apps/movim_ynh
Other
13 stars 6 forks source link

Update package for YunoHost 2.4 and download source code #28

Closed jeromelebleu closed 8 years ago

jeromelebleu commented 8 years ago

This PR changes the following:

src386 commented 8 years ago

Hi, thanks, let me take a look at this before I merge. backup and restore are useless because movim data are stored in metronome. mysql is only for cache.

src386 commented 8 years ago

This pull request makes movim_ynh depend on Yunohost 2.4. Yunohost 2.4 is available only for Debian Jessie, is it relevant to keep sysvinit scripts ?

src386 commented 8 years ago

Not sure if it's a good idea to drop YunoHost-2.2 support, it's too early.

src386 commented 8 years ago

Thanks again, @jeromelebleu . Your code is really clean, that's a huge improvement for movim_ynh.

download and update source code using git - it meanly allows one to trust easier the source code integrity, ease the new version update and make lighter the repository

merged.

make use of new YunoHost helpers coming with the 2.4 version

I wanted to keep yh2.2 compatibility, so I had to backport the helpers and edit manifest.json (boolean and ynh version requirement). If /usr/share/yunohost/helpers does not exists, they are loaded from ./_helpers.

add backup and restore scripts

Removed since they doesn't work and are not easy to test (not to say it's a real pain in yunohost). Anyway Movim doesn't store critical data, it's just cache.

redirect to the SSO on logging out

merged

be less verbose with some commands - i.e. composer and systemctl

removed because I want verbose output.

jeromelebleu commented 8 years ago

With pleasure!

Yunohost 2.4 is available only for Debian Jessie, is it relevant to keep sysvinit scripts ?

You're right, it's useless in that case.

Not sure if it's a good idea to drop YunoHost-2.2 support, it's too early.

I can just highly recommend to upgrade to YunoHost 2.4... There is no more updates and fixes since ~1 year on the 2.2 version. Moreover, this new version bring a lot of new features - especially for app packaging.

add backup and restore scripts

Removed since they doesn't work and are not easy to test (not to say it's a real pain in yunohost).

We should document that, sorry. They were working in my PR, but I think this line broke it since backup and restore scripts are not - yet - executed in the same folder than the app package - as it is for the other scripts. Anyway, to test it - and only this app backup, you can execute the following:

# create a backup of movim app only named movim-backup
yunohost backup create --ignore-hooks --apps movim --name movim-backup --verbose
# delete the current app - otherwise restoration will not be possible
yunohost app remove movim
# restore the previous backup
yunohost backup restore movim-backup --verbose

Anyway Movim doesn't store critical data, it's just cache.

I think that it's always useful to have those scripts to easily restore a system ~ at a previous state, but I let you decide...

src386 commented 8 years ago

I didn't know it was possible to backup & restore a single app, it makes things easier. I'll take a look, Thanks.

jeromelebleu commented 8 years ago

You're welcome! And by the way, thanks a lot for this package, I think we should consider - if i's not already in progress - to add it to the "official" app list!

jeromelebleu commented 8 years ago

I've forgot to argue on one point...

be less verbose with some commands - i.e. composer and systemctl

removed because I want verbose output.

The fact is that git, systemctl and composer use stderr even for non-error messages. It results in a lot of Warning: ... from YunoHost side... One possibility if you want to keep verbose output can be to redirect stderr to stdout, but we will then not distinguish errors from information.