search

movio / bramble

A federated GraphQL API gateway
https://movio.github.io/bramble/
MIT License
497 stars 55 forks source link

Add handling of ast.Interface to kindToStr #114

Closed lucianjon closed 2 years ago

lucianjon commented 2 years ago

The previous case statement wasn't actually exhaustive as it excluded interface. Now if kindToStr gets an interface it'll return the correct string. The special case for ast.InputObject and ast.Object were kept for backwards compatibility.

codecov-commenter commented 2 years ago

Codecov Report

Merging #114 (4749320) into main (4b3dd2e) will increase coverage by 0.21%. The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #114      +/-   ##
==========================================
+ Coverage   68.52%   68.73%   +0.21%     
==========================================
  Files          24       24              
  Lines        2618     2610       -8     
==========================================
  Hits         1794     1794              
+ Misses        689      681       -8     
  Partials      135      135
Impacted Files Coverage Δ
plugins/meta.go 10.07% <0.00%> (+0.54%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4b3dd2e...4749320. Read the comment docs.